Add Python 3.13 compatibility #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
========================================
+ Coverage 94.2% 94.4% +0.1%
========================================
Files 23 23
Lines 1753 1776 +23
========================================
+ Hits 1653 1677 +24
+ Misses 100 99 -1
|
3 tasks
pjbull
changed the title
jayqi
requested changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Python 3.13, which was released Oct 1, 2024.
The tricky thing here is that the glob logic in CPython has been totally updated and moved around. We depend on the pre-313 private API for the parsing of the pattern language and inclusion/exclusion as we do the tree walking. Vendored that logic for the time being, but we should try a different implementation.
Issue #479 has been filed to track making the right improvements to the globbing logic.
Other changes and todos for 3.13:
.full_matchadded (needs test).from_uriadded (needs test)follow_symlinkskwarg added tois_fileadded as no-opfollow_symlinkskwarg added tois_diradded as no-opnewlinekwarg added toread_textrecurse_symlinkskwarg added toglobadded as no-oppatternparameter forglobcan be PathLikerecurse_symlinkskwarg added torglobadded as no-oppatternparameter forrglobcan be PathLikeBonus:
is_dirandis_filehad the same implementation for every provider, so refactored back to parent class.Closes #472